[Webkit-unassigned] [Bug 91214] [EFL] Add WebMemorySampler feature.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91214





--- Comment #33 from Ryuan Choi <ryuan.choi at samsung.com>  2012-08-27 03:02:58 PST ---
(From update of attachment 160672)
View in context: https://bugs.webkit.org/attachment.cgi?id=160672&action=review

> Source/WebKit2/PlatformEfl.cmake:189
> +    -DENABLE_MEMORY_SAMPLER=1

This is not needed if you want to add it in OptionsTizen.cmake.

> Source/WebKit2/Shared/efl/WebMemorySamplerEfl.cpp:71
> +inline void appendMemoryStats(WebMemoryStatistics& webKitMemoryStats, String key, size_t value)

const String& key

> Source/WebKit2/Shared/efl/WebMemorySamplerEfl.cpp:106
> +    FILE* fMemoryStatus = fopen(processPath, "r");
> +    if (fMemoryStatus) {

empty line is preffered.

> Source/WebKit2/Shared/efl/WebMemorySamplerEfl.cpp:118
> +#endif
> +    return applicationStats;

need empty line.

> Source/WebKit2/Shared/efl/WebMemorySamplerEfl.cpp:134
> +#endif
> +    return String();

need empty line.

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:748
> +#if ENABLE(MEMORY_SAMPLER)
> +    static bool memorySampler = false;
> +    static const char environMemorySampler[] = "MEMORY_SAMPLER";
> +
> +    if (!memorySampler && getenv(environMemorySampler)) {
> +        WKRetainPtr<WKDoubleRef> interval(AdoptWK, WKDoubleCreate(0.0));
> +        WKContextStartMemorySampler(ewk_context_WKContext_get(context), interval.get());
> +        memorySampler = true;
> +    }
> +#endif

Is this related to context? I think that it should be in ewk_context.

> Source/cmake/OptionsEfl.cmake:81
> +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MEMORY_SAMPLER ON)

I am not sure whether we can add this.
But I think that we are using GLIB_SUPPORT for similar reason, 
So it can be reasonable although this option is only WebKit2/MAC and WebKit2/Efl now.

Anyway, to add this, you should also put this in WebKitFeatures.cmake and cmakeconfig.cmake.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.