[Webkit-unassigned] [Bug 94925] [EFL][UT] Updating ut framework fo wk1

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=94925





--- Comment #4 from Ryuan Choi <ryuan.choi at samsung.com>  2012-08-25 10:43:36 PST ---
(From update of attachment 160433)
View in context: https://bugs.webkit.org/attachment.cgi?id=160433&action=review

> Source/WebKit/efl/ChangeLog:4
> +        [EFL][UT]Refactoring an implementation of testing framework for wk1.
> +        https://bugs.webkit.org/show_bug.cgi?id=94925

Bug title and change log are different.

> Source/WebKit/efl/ChangeLog:10
> +        and lastly to make framework simplier and easier to use.

I am not good english speaker, so I am not sure whether `simplier` is correct.

> Source/WebKit/efl/tests/UnitTestUtils/EWKTestBase.cpp:78
> +    UNUSED_PARAM(webView);
> +    UNUSED_PARAM(eventInfo);

I think that we can just remove parameter name because this is cpp.

> Source/WebKit/efl/tests/UnitTestUtils/EWKTestBase.cpp:84
> -bool EWKTestBase::runTest(const char* url, void (*event_callback)(void*, Evas_Object*, void*), const char* event_name, void* event_data)
> +void EWKTestBase::runTest(const char* url)

In my two cents, runTest looks ambiguous.
WebKit2/Efl uses loadUrlSync (although I want to suggest waitUntilLoadFinished with ewk_view_uri_set like waitUntilTitleChanged approach)

> Source/WebKit/efl/tests/UnitTestUtils/EWKTestView.cpp:80
> -Evas* EWKTestView::evas()
> +bool EWKTestView::loadUrl(const char* url)

I think that this wrapper is not necessary.

> Source/WebKit/efl/tests/UnitTestUtils/EWKTestView.cpp:90
> +Evas_Object* EWKTestView::mainFrame()
>  {
> -    if (!m_webView.get())
> -        return;
> -
> -    evas_object_smart_callback_del(m_webView.get(), eventName, callback);
> -    evas_object_smart_callback_add(m_webView.get(), eventName, callback, ptr);
> +    return ewk_view_frame_main_get(m_webView);
>  }

Ditto.

> Source/WebKit/efl/tests/UnitTestUtils/EWKTestView.h:-66
> -    OwnPtr<Evas_Object> m_webView;

Can I know why you change OwnPtr<Evas_Object> to Evas_Object* ?

> Source/WebKit/efl/tests/test_ewk_view.cpp:35
> +    EXPECT_EQ(EINA_FALSE, ewk_view_editable_get(webView()));

ASSERT_FALSE?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.