[Webkit-unassigned] [Bug 91214] [EFL] Add WebMemorySampler feature.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91214





--- Comment #22 from JungJik Lee <jungjik.lee at samsung.com>  2012-08-24 11:48:03 PST ---
(From update of attachment 160413)
View in context: https://bugs.webkit.org/attachment.cgi?id=160413&action=review

>> Source/WebKit2/Shared/efl/WebMemorySamplerEfl.cpp:2
>> + * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
> 
> Do we need this?

I'm not sure. the template of this code is based on Apple code, so I leave it. Does this line cause any legal issue?

>> Source/WebKit2/Shared/efl/WebMemorySamplerEfl.cpp:81
>> +            } else if (foundKeyName) {
> 
> When program comes in? Seems 'foundKeyName' always 'false' before if condition.

Yes, if the token has not colon, it will be the value.

>> Source/WebKit2/Shared/efl/WebMemorySamplerEfl.cpp:109
>> +    return applicationStats;
> 
> Then this would be 'return 0'

this function returns structure type.

>> Source/WebKit2/Shared/efl/WebMemorySamplerEfl.cpp:114
>> +    String processName;
> 
> We would put this line inside if condition.

I don't understand the reason.

>> Source/WebKit2/Shared/efl/WebMemorySamplerEfl.cpp:116
>> +    sprintf(processPath, "/proc/%d/status", getpid());
> 
> snprintf?

Good point, I'll fix it right now.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.