[Webkit-unassigned] [Bug 94913] New: Stylechecker warns about comparison to zero when comparing to 0.5

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 24 01:39:43 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=94913

           Summary: Stylechecker warns about comparison to zero when
                    comparing to 0.5
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: dominik.rottsches at intel.com


Stylechecker comlains about the following line
    if (fabs(result - value) == 0.5 && (result & 1))
with 
"Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]"

I believe that's a mistake.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list