[Webkit-unassigned] [Bug 93755] ShadowRoot insertion point change aborts css transition

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93755





--- Comment #16 from Hajime Morrita <morrita at google.com>  2012-08-23 17:57:09 PST ---
(From update of attachment 160103)
View in context: https://bugs.webkit.org/attachment.cgi?id=160103&action=review

>> Source/WebCore/dom/ElementShadow.cpp:95
>> +        shadowHost->lazyAttach();
> 
> Didn't we have something called re-attach on Node?

That isn't lazy. But I agree that it might be nice to have lazyReattach().

>> Source/WebCore/dom/ElementShadow.cpp:220
>> +                n->lazyAttach();
> 
> Are you sure we need something as drastic as reattach? Given that you're calling lazyAttach, you might be ok with just setNeedsStyleRecalc?

- We need deatch() here because the shape of the render tree is going to change.
- lazyAttach() is basically setting the "attached" flag + setNeedsStyleRecalc().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.