[Webkit-unassigned] [Bug 91844] [EFL][WK2] Plugin process implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91844





--- Comment #19 from Ryuan Choi <ryuan.choi at samsung.com>  2012-08-23 16:53:32 PST ---
(From update of attachment 159885)
View in context: https://bugs.webkit.org/attachment.cgi?id=159885&action=review

> Source/WebKit2/PluginProcess/efl/PluginProcessMainEfl.cpp:77
> +    JSC::initializeThreading();
> +    WTF::initializeMainThread();

I think that ScriptController::initializeThreading looks better.

> Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:50
> +#if PLATFORM(GTK) || (PLATFORM(EFL) && USE(CAIRO))

I think that USE(CAIRO) looks enough but we should check win-cairo port.

> Source/cmake/OptionsEfl.cmake:125
> +IF (ENABLE_WEBKIT2)
> +    SET(ENABLE_PLUGIN_PROCESS 1)
> +ENDIF ()

Is it working although we disabled ENABLE_ECORE_X or can not find ecore-x ?

> Tools/Scripts/webkitperl/FeatureList.pm:325
> -      define => "ENABLE_NETSCAPE_PLUGIN_API", default => !isEfl(), value => \$netscapePluginAPISupport },
> +      define => "ENABLE_NETSCAPE_PLUGIN_API", default => 1, value => \$netscapePluginAPISupport },

If possible, can we separate this ?

It's because ENABLE_NETSCAPE_PLUGIN_API is not only for plugin process
and I hope that it is enabled as soon as possible.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.