[Webkit-unassigned] [Bug 94751] [chromium] Use an opaque type for texture priority

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=94751


Dana Jansens <danakj at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |danakj at chromium.org




--- Comment #15 from Dana Jansens <danakj at chromium.org>  2012-08-23 14:22:17 PST ---
(In reply to comment #14)
> (In reply to comment #13)
> > (In reply to comment #12)
> > > (In reply to comment #11)
> > 
> > > > Why do you need a separate mechanism for this?  It seem like if you add additional information that can be used to prioritize textures, then the texture manager should be the one using it.
> > > 
> > > Is this perhaps in the context of the impl thread doing some management, since that's where GPU memory manager limits arrive via the graphics context on that thread?
> > 
> > That's exactly it.  This is so that the impl thread can evict "some but not all" textures.  The impl thread will need to guess which textures the main thread would have deleted (were the main thread to have made the choice), since it doesn't have direct access to the prioritized texture manager.
> 
> Adding additional data to priority isn't going to help the compositor thread.  Priority is a main-thread only concept, at this point.
> 
> What about making the texture manager thread-safe and accessible by both threads? I feel like this need has come up before (removing just some textures without a commit) and I suspect impl-side painting is going to need to touch on this as well.

Main thread is blocked when the PTM sorts all the textures by priority. This sorted list shouldn't be modified when the main thread isn't blocked, IIRC? So impl should be able to just read that list and drop the top textures from it until satisfied. And main thread should be able to do the same later and make the same choices?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.