[Webkit-unassigned] [Bug 94843] New: Nuke markBoxForRelayoutAfterSplit

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=94843

           Summary: Nuke markBoxForRelayoutAfterSplit
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: jchaffraix at webkit.org
                CC: inferno at chromium.org


This function makes me sad, mostly because of the FIXME:

static void markBoxForRelayoutAfterSplit(RenderBox* box)
{
    // FIXME: The table code should handle that automatically. If not,
    // we should fix it and remove the table part checks.
    if (box->isTable()) {
        // Because we may have added some sections with already computed column structures, we need to
        // sync the table structure with them now. This avoids crashes when adding new cells to the table.
        toRenderTable(box)->forceSectionsRecalc();
    } else if (box->isTableSection())
        toRenderTableSection(box)->setNeedsCellRecalc();

    box->setNeedsLayoutAndPrefWidthsRecalc();
}

Now that we have introduced willBeRemovedFromTree / insertedIntoTree we should be able to remove it from the tree and rely on the previous notifications instead.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.