[Webkit-unassigned] [Bug 93755] ShadowRoot insertion point change aborts css transition

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93755





--- Comment #15 from Dimitri Glazkov (Google) <dglazkov at chromium.org>  2012-08-23 09:20:42 PST ---
(From update of attachment 160103)
View in context: https://bugs.webkit.org/attachment.cgi?id=160103&action=review

> Source/WebCore/ChangeLog:10
> +        shadow host's style clear. So when distribution is changed, no css

The meaning of "clear" here is unclear :)

Do you mean it clears the style of host's style?

> Source/WebCore/dom/ElementShadow.cpp:92
> +    // FIXME: Suppose that some css transition is applied to a shadow host and
> +    // new shadow roots are attached during the transition. In this case,
> +    // detaching the shadow host reset its style and breaks the css transition.
> +    // However, for replace elements, e.g. IMG, it is required to re-create
> +    // shadow host's renderer at the first time when an author shadow root is
> +    // added. So it might be better to set some flag here and to recreate
> +    // a renderer in Element::recalcStyle.

This comment probably belongs in a bug. Reference bug here and enjoy using a much shorter explanation :)

> Source/WebCore/dom/ElementShadow.cpp:95
> +        shadowHost->detach();
> +        shadowHost->lazyAttach();

Didn't we have something called re-attach on Node?

> Source/WebCore/dom/ElementShadow.cpp:220
> +                n->detach();
> +                n->lazyAttach();

Are you sure we need something as drastic as reattach? Given that you're calling lazyAttach, you might be ok with just setNeedsStyleRecalc?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.