[Webkit-unassigned] [Bug 91844] [EFL][WK2] Plugin process implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91844





--- Comment #17 from Simon Hausmann <hausmann at webkit.org>  2012-08-23 00:27:49 PST ---
(From update of attachment 159885)
View in context: https://bugs.webkit.org/attachment.cgi?id=159885&action=review

> Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:107
>      return XDefaultScreen(NetscapePlugin::x11HostDisplay());
>  #elif PLATFORM(GTK)
>      return gdk_screen_get_number(gdk_screen_get_default());
> +#elif PLATFORM(EFL)
> +    return ecore_x_screen_index_get(ecore_x_default_screen_get());
>  #else

I wonder why we have this #ifdef mess here when all we need is to use X11 functions. It sounds like to me that the current PLATFORM(QT) code path could be generalized to work with Gtk and EFL and all that remains in #ifdefs is the function to provide the Display*.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.