[Webkit-unassigned] [Bug 94755] New: [CSS Shaders] Create constants for vertex attribute sizes and offsets

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=94755

           Summary: [CSS Shaders] Create constants for vertex attribute
                    sizes and offsets
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: mvujovic at adobe.com
            Blocks: 71392


Right now, vertex attribute sizes are literal constants in CustomFilterMesh.cpp like this:
static const unsigned AttachedMeshVertexSize = 4 + // vec4 a_position
    2 + // vec2 a_texCoord
    2; // vec2 a_meshCoord

It would be better to make them public members of CustomFilterMesh like this:
static const unsigned PositionAttribSize = 4;
static const unsigned TexAttribSize = 2;

That way, we can use the constants when we bind the attributes in FECustomFilter::bindProgramAndBuffers.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.