[Webkit-unassigned] [Bug 94736] New: [CSS Shaders] [ANGLE] RenameFunction::RenameFunction may store references to temporary string

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 22 11:31:40 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=94736

           Summary: [CSS Shaders] [ANGLE] RenameFunction::RenameFunction
                    may store references to temporary string
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: CSS
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: jnetterfield at rim.com
                CC: rwlbuis at gmail.com, achicu at adobe.com,
                    mvujovic at adobe.com


http://code.google.com/p/angleproject/issues/detail?id=360

When RenameFunction::RenameFunction(const TString& oldFunctionName, const TString& newFunctionName) is called from TCompiler::rewriteCSSShader(TIntermNode*), references to the temporaries oldFunctionName and newFunctionName are stored as mOldFunctionName and mNewFunctionName. This results in undefined behaviour in visitAggregate.

Possible fix in RenameFunction.h:
 private:
-    const TString& mOldFunctionName;
+    const TString mOldFunctionName;
-    const TString& mNewFunctionName;
+    const TString mNewFunctionName;

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list