[Webkit-unassigned] [Bug 91351] [EFL][WK2] Add ewk_view_user_agent_set / ewk_view_user_agent_get API.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91351


Kenneth Rohde Christiansen <kenneth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kenneth at webkit.org




--- Comment #38 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2012-08-22 07:19:03 PST ---
(In reply to comment #37)
> (In reply to comment #35)
> > (From update of attachment 159894 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=159894&action=review
> > 
> > > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:1396
> > > +Eina_Bool ewk_view_user_agent_set(Evas_Object* ewkView, const char* userAgent)
> > > +{
> > 
> > Qt WebKit1 had the more powerful api of userAgentForUrl(...) where you could return a different UA for certain URLs.
> > 
> > Maybe such a similar api (not callback based, as that would block) could be useful
> 
> I would advise against such a userAgentForUrl() API and I think it was a mistake to have it in WK1, because it has direct performance implications. Every single resource request will have to do a synchronous callback into this API and it will usually also involve converting from KURL to whatever url type is used on the API level.

If it should be done it could be like a hashmap that you add to like "addUserAgentForOrigin(...)" then there would also be less conversion and it would not need to talk to the UI side. Anyway :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.