[Webkit-unassigned] [Bug 93838] [EFL] Use vertical slider theme when the slider is vertical

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93838





--- Comment #7 from KwangYong Choi <ky0.choi at samsung.com>  2012-08-21 23:01:06 PST ---
(In reply to comment #6)
> (In reply to comment #5)
> > (In reply to comment #4)
> > > (From update of attachment 159641 [details] [details] [details])
> > > View in context: https://bugs.webkit.org/attachment.cgi?id=159641&action=review
> > > 
> > > >>> Source/WebCore/platform/efl/RenderThemeEfl.cpp:769
> > > >>> +    const struct ThemePartDesc* desc;
> > > >> 
> > > >> I know this construction was already like this, but since you are touch this part you can leave out the `struct' part, it's an unneeded C-ism.
> > > > 
> > > > You mean, remove const, right?
> > > 
> > > No he means use:
> > > ThemePartDesc* desc;
> > > 
> > > This is valid in C++.
> > 
> > OK.
> 
> Actually, const ThemePartDesc* desc ;)

But, is it really required? All the other parts using 'struct ThemePartDesc'. It breaks code consistency.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.