[Webkit-unassigned] [Bug 83512] FontMetrics.unitsPerEm(), FontPlatformData.orientation(), SimpleFontData::platformBoundsForGlyph are not implemented on Chromium Windows

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 21 13:26:03 PDT 2012


--- Comment #11 from Tony Chang <tony at chromium.org>  2012-08-21 13:25:59 PST ---
(From update of attachment 159696)
View in context: https://bugs.webkit.org/attachment.cgi?id=159696&action=review

The code change seems fine. Did you mean to set r? for this patch?

> Source/WebCore/ChangeLog:11
> +        1. FontMetrics.unitsPerEm() always returns the default value (gDefaultUnitsPerEm = 1000).
> +        2. FontPlatformData.orientation() always returns Horizontal.
> +        3. SimpleFontData::platformBoundsForGlyph() always returns FloatRect().

It would be good to note what each of these changes does. For example, I assume (2) does nothing right now (doesn't change any layout tests).  (1) and (3) probably causes some text to change in size, but it would be good to mention which tests demonstrate this.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list