[Webkit-unassigned] [Bug 89616] nrwt: use scm instead of calling svn directly to get the revision in json results generator

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=89616





--- Comment #6 from Zan Dobersek <zandobersek at gmail.com>  2012-08-21 11:36:44 PST ---
(In reply to comment #5)
> Is this approach possible or are there some other caveats?

One I just discovered is the resulting test-webkitpy failures.

[917/1577] webkitpy.layout_tests.run_webkit_tests_integrationtest.MainTest.test_repeat_each_iterations_num_tests erred:
  Traceback (most recent call last):
...
    File "/home/zan/Dev/webkit/weekend/Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py", line 388, in _get_svn_revision
      scm = detect_scm_system(in_directory, filesystem=self._filesystem)
    File "/home/zan/Dev/webkit/weekend/Tools/Scripts/webkitpy/common/checkout/scm/detection.py", line 81, in detect_scm_system
      return SCMDetector(filesystem, Executive()).detect_scm_system(path, patch_directories)
    File "/home/zan/Dev/webkit/weekend/Tools/Scripts/webkitpy/common/checkout/scm/detection.py", line 69, in detect_scm_system
      if SVN.in_working_directory(absolute_path):
    File "/home/zan/Dev/webkit/weekend/Tools/Scripts/webkitpy/common/checkout/scm/svn.py", line 93, in in_working_directory
      exit_code = Executive().run_command(svn_info_args, cwd=path, return_exit_code=True)
    File "/home/zan/Dev/webkit/weekend/Tools/Scripts/webkitpy/common/system/executive.py", line 402, in run_command
      close_fds=self._should_close_fds())
    File "/home/zan/Dev/webkit/weekend/Tools/Scripts/webkitpy/common/system/executive.py", line 458, in popen
      return subprocess.Popen(*args, **kwargs)
    File "/usr/lib/python2.7/subprocess.py", line 679, in __init__
      errread, errwrite)
    File "/usr/lib/python2.7/subprocess.py", line 1249, in _execute_child
      raise child_exception
  OSError: [Errno 2] No such file or directory: '/test.checkout/LayoutTests'

common.checkout.scm.svn runs commands on the real filesystem and not the mock filesystem used in settings.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.