[Webkit-unassigned] [Bug 91812] Implement UndoManager's automatic DOM transactions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91812


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #159629|review?                     |review+
               Flag|                            |




--- Comment #14 from Ryosuke Niwa <rniwa at webkit.org>  2012-08-21 09:54:01 PST ---
(From update of attachment 159629)
View in context: https://bugs.webkit.org/attachment.cgi?id=159629&action=review

> Source/WebCore/dom/CharacterData.cpp:193
> +#if ENABLE(UNDO_MANAGER)
> +    if (UndoManager::isRecordingAutomaticTransaction(this)) {
> +        const String& replacingData = newData.substring(offsetOfReplacedData, newLength);
> +        const String& replacedData = m_data.substring(offsetOfReplacedData, oldLength);
> +        UndoManager::addTransactionStep(DataReplacingDOMTransactionStep::create(this, offsetOfReplacedData, oldLength, replacingData, replacedData));
> +    }
> +#endif

Why don't we do this in dispatchModifiedEvent to follow the pattern?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.