[Webkit-unassigned] [Bug 51450] Glyphs in vertical text tests are rotated 90 degrees clockwise on Chromium Windows

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51450





--- Comment #53 from Koji Ishii <kojiishi at gmail.com>  2012-08-21 05:41:15 PST ---
(In reply to comment #50)
> This looks great!
> 
> The patch is still pretty big making it hard for me to review it.  Here are some suggestions on how to make it smaller:
> 
> 1) First land code that is not behind #if ENABLE(OPENTYPE_VERTICAL) as separate patches. Ideally, there would be test cases for each function as they are implemented, but that may not be possible.
> 
> 2) Land the code needed that is behind #if ENABLE(OPENTYPE_VERTICAL).
> 
> 3) Land the change to features.gypi + layout test results.
> 
> That way, if there are any perf regressions, it's easy to roll out step (3) only.

Thank you Tony for the prompt and wonderful suggestion. A couple of changes in font metrics required rebaselining non-vertical cases, so I agree that your suggestion makes such changes separated from others. I'll reactivate 83512 and put item 1 into it, make another bug, and then back to this bug for item 3.

Thank you again.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.