[Webkit-unassigned] [Bug 93290] getBBox() returns (0, 0) when width or height is zero.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93290





--- Comment #14 from Changhun Kang <temoochin at company100.net>  2012-08-21 05:15:15 PST ---
I appreciate for your review.
> (From update of attachment 159282 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=159282&action=review
> 
> The patch looks good in general, i wonder about the term "is in error" . Currently you just disable rendering for zero and negative case. A test with negative width/height/r/rx/ry would be great as well.

I modified just zero-width or zero-height cases' behavior. So I add some those cases. If I check some negative value cases, does it need to make another test file? or just add in same file? Then, can the file name be misleading..?



> 
> > Source/WebCore/rendering/svg/RenderSVGEllipse.cpp:74
> > +    bool renderable = m_radii.width() && m_radii.height();
> 
> No extra variable needed, you just call it once.
> 
> > Source/WebCore/rendering/svg/RenderSVGRect.cpp:81
> > +    bool renderable = boundingBoxSize.width() && boundingBoxSize.height();
> 
> Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.