[Webkit-unassigned] [Bug 93597] Add DeviceController to support DOMWindow device events

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93597





--- Comment #45 from Kihong Kwon <kihong.kwon at samsung.com>  2012-08-20 19:16:43 PST ---
(In reply to comment #44)
> (From update of attachment 159363 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=159363&action=review
> 
> OK.  This is getting close.  Can we remove the PROXIMITY_EVENTS-specific code from this patch?  It doesn't seem like it actually does anything because nothing inherits from DeviceClient.
> 
> Rather than adding support for PROXIMITY_EVENTS in this patch, I'd prefer if we:
> 1) Landed this patch
> 2) Changed the existing device code to use this mechanism (probably one per patch)
> 3) Added support for device proximity
> 
> Is that a reasonable course of action?

I think so. I will do that.

> > Source/WebCore/page/DeviceController.cpp:116
> > +        if (!listeners[i]->document()->activeDOMObjectsAreSuspended())
> 
> Is this the right semantics for suspended documents?  It's fine to just drop the events on the floor?

I think there is no problem about dropping events. this is only for specific window which is suspended.

IMHO, window doesn't need to get a device event, when it's state is suspeneded.
And window can receive a device event from client if it gets back to active state because listener still alive in the listeners.

Thank you for reviewing. :-)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.