[Webkit-unassigned] [Bug 51450] Glyphs in vertical text tests are rotated 90 degrees clockwise on Chromium Windows

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 20 14:50:57 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=51450





--- Comment #50 from Tony Chang <tony at chromium.org>  2012-08-20 14:51:29 PST ---
This looks great!

The patch is still pretty big making it hard for me to review it.  Here are some suggestions on how to make it smaller:

1) First land code that is not behind #if ENABLE(OPENTYPE_VERTICAL) as separate patches. Ideally, there would be test cases for each function as they are implemented, but that may not be possible.

2) Land the code needed that is behind #if ENABLE(OPENTYPE_VERTICAL).

3) Land the change to features.gypi + layout test results.

That way, if there are any perf regressions, it's easy to roll out step (3) only.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list