[Webkit-unassigned] [Bug 93832] text-combine falls back to none rather than scale when wider than 1.1em

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93832





--- Comment #15 from Koji Ishii <kojiishi at gmail.com>  2012-08-20 12:07:17 PST ---
(In reply to comment #14)
> >emphasis
> 
> I checked text-combine with text-emphasis-style behavior.
> Emphasis don't work well in Chromium Linux Nightly 20.0.1240.0(152297) on my Ubuntu 12.04.
> 
> > overline, and link
> 
> Please read my ChangeLog.
> text-decoration is known issue.

Ah, I see, thank you. It's probably better to enter a bug, and write the bug #.

> * platform/mac/fast/dynamic/text-combine-expected.png: Removed.
> * platform/mac/fast/text/international/text-combine-image-test-expected.png: Removed.

Why are these two files removed, not rebaselined?

> * platform/chromium-linux/fast/writing-mode/combine-compress-expected.png: Added.
> * platform/chromium-linux/fast/writing-mode/combine-compress-expected.txt: Added.
> * platform/mac/fast/writing-mode/combine-compress-expected.txt: Added.

Why no mac/fast/writing-mode/combine-compress-expected.png?

> RenderCombineText::combineText

It looks to me that, in the original code, when m_isCombined is set, font is set to setOrientation(Horizontal) and RenderText::setTextInternal is called, but the patch changes the rule. Setting m_isCombined = true at line 124 looks better to me. Is this intentional and I'm missing something?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.