[Webkit-unassigned] [Bug 94182] [chromium] Implement Link Preview (a.k.a. on-demand zoom)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=94182





--- Comment #6 from Alexandre Elias <aelias at chromium.org>  2012-08-20 10:44:45 PST ---
(In reply to comment #5)
> This review is mostly questions.  The the main thing I'd like to change is to remove generatedByLinkPreview.  Is there a way around adding that state to WebKit?
> 
> >> Source/WebKit/chromium/public/WebInputEvent.h:382
> >> +    bool generatedByLinkPreview;
> > 
> > Here's a thought.  This value could be replaced by "float errorDistance;"  The browser could send down a value corresponding to basically the size of a finger and it could feed into the scoring function.  When the tap already has been disambiguated, the error can be set to zero.
> 
> Is there a way to keep this state in Chromium?  It's not really a concern of WebKit...  All that might be required is for the RenderView to remember whether it is currently showing a link previous popup.

We don't want the renderer to make assumptions about what the browser is doing.  The browser could dismiss the popup for complex reasons.  And it would also be messy to add more criss-crossing ViewMsgs to keep the renderer in sync with whatever the browser is doing.

The "errorDistance" actually is a logical property of an input event -- conceptually, there is a zone of precision you can expect for a given input event, whether due to hardware or finger imprecision.   So I think we should add the value -- it's natural enough that I have the feeling we'll even find different uses for it in the future..

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.