[Webkit-unassigned] [Bug 73819] [Gtk] Dojo toggle buttons should expose ROLE_TOGGLE_BUTTON not ROLE_PUSH_BUTTON

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73819


Alejandro Piñeiro <apinheiro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #158769|0                           |1
        is obsolete|                            |
 Attachment #159127|0                           |1
        is obsolete|                            |
 Attachment #158769|review?                     |
               Flag|                            |
 Attachment #159127|review?                     |
               Flag|                            |
 Attachment #159393|                            |review?
               Flag|                            |




--- Comment #23 from Alejandro Piñeiro <apinheiro at igalia.com>  2012-08-20 04:44:56 PST ---
Created an attachment (id=159393)
 --> (https://bugs.webkit.org/attachment.cgi?id=159393&action=review)
Fixes the bug

This last update adds chromium platform specifics. I didn't add it on the previous one because I only searched platform specific code on WebCore, as with gtk and mac, but it seems that most specific accessibility related code for chromium resides at WebKit level.

As with mac, I tried to make a ToggleButton->Button role matching, but I was not able to do that. This is because chromium WebAccessibilityRole needs to be a perfect 1-to-1 match with WebCore AccessibilityRole. In fact, at WebAccessibilityObject::roleValue, the matching rule is a static_cast of the AccessibilityObject wrapped.

So in the end I needed to add a new WebAccessibilityRole, WebAccessibilityRoleToggleButton. I also needed to update AccessibilityUIElementChromium in order to print the proper role name.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.