[Webkit-unassigned] [Bug 72811] [Gtk] No accessible caret-moved events found in certain content

Sun Aug 19 21:02:30 PDT 2012

https://bugs.webkit.org/show_bug.cgi?id=72811

--- Comment #7 from chris fleizach <cfleizach at apple.com>  2012-08-19 21:03:07 PST ---
(From update of attachment 159321)
View in context: https://bugs.webkit.org/attachment.cgi?id=159321&action=review

> Source/WebCore/accessibility/gtk/AccessibilityObjectAtk.cpp:85
> +    if (ariaRoleAttribute() != UnknownRole || parent->ariaRoleAttribute() != UnknownRole)

It seems that just asking the parent if it's not an unknown wouldn't account for
<div><div><span>element</span></div></div>, or anything with nested unknowns. I don't see what's special about a parent having unknown role, but not a grandparent.

> Source/WebCore/accessibility/gtk/AccessibilityObjectAtk.cpp:91
> +    if ((node() && node()->hasTagName(spanTag)) || (renderObject && renderObject->isAnonymousBlock())) {

It seems weird to special case spanTag here. That seems like a level of detail that platform wrapper shouldn't have to know. 
It also seems weird that these isBody checks are inside this block. Seems like you could just check for that outside this block.

The logic change here appears to be to cause <spans> and anonymous render blocks to be ignored, but doesn't WebCore do that already?

> Source/WebCore/accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:860
> +                    || (!coreObject->isControl() && !coreObject->textUnderElement().isEmpty()))

presumably this would make all kinds of things have the text interface. Tables, Lists, <body> element. Is that intended?
Also if you're checking textUnderElement(), does the renderer->childrenInline() check matter? It seems that anything that has textUnder it would be a candidate

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.