[Webkit-unassigned] [Bug 93290] getBBox() returns (0, 0) when width or height is zero.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93290


Dirk Schulze <krit at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #159282|review?                     |review-
               Flag|                            |




--- Comment #12 from Dirk Schulze <krit at webkit.org>  2012-08-19 08:03:07 PST ---
(From update of attachment 159282)
View in context: https://bugs.webkit.org/attachment.cgi?id=159282&action=review

The patch looks good in general, i wonder about the term "is in error" . Currently you just disable rendering for zero and negative case. A test with negative width/height/r/rx/ry would be great as well.

> Source/WebCore/rendering/svg/RenderSVGEllipse.cpp:74
> +    bool renderable = m_radii.width() && m_radii.height();

No extra variable needed, you just call it once.

> Source/WebCore/rendering/svg/RenderSVGRect.cpp:81
> +    bool renderable = boundingBoxSize.width() && boundingBoxSize.height();

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.