[Webkit-unassigned] [Bug 91832] [EFL][WK2] Implemented color chooser proxy and input picker interface

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91832





--- Comment #43 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-08-17 23:29:48 PST ---
(From update of attachment 159079)
View in context: https://bugs.webkit.org/attachment.cgi?id=159079&action=review

> Source/WebKit2/UIProcess/efl/WebColorChooserProxyEfl.h:35
> +

Don't you need to declare Color namespace as Qt port ?

http://trac.webkit.org/browser/trunk/Source/WebKit2/UIProcess/qt/WebColorChooserProxyQt.h#L36

> Source/WebKit2/UIProcess/efl/WebColorChooserProxyEfl.h:46
> +    virtual ~WebColorChooserProxyEfl();

I think we don't need to use virtual keyword in derived class. Look at Qt port. 
http://trac.webkit.org/browser/trunk/Source/WebKit2/UIProcess/qt/WebColorChooserProxyQt.h#L50

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.