[Webkit-unassigned] [Bug 91912] Adding "all" to -webkit-user-select

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91912





--- Comment #45 from Alice Cheng <alice_cheng at apple.com>  2012-08-17 14:58:21 PST ---
(From update of attachment 159176)
View in context: https://bugs.webkit.org/attachment.cgi?id=159176&action=review

>>>> Source/WebCore/page/EventHandler.cpp:834
>>>> +        newSelection.setExtent(targetPosition);
>>> 
>>> Don't we need to set this to the beginning of rootUserSelectAllForMousePressNode when the previous if condition is true?
>> 
>> Why? Do you mean setting the base or extent?
> 
> Extent. If rootUserSelectAllForMousePressNode is not null, then we're still in -webkit-user-select: all, right?

mousePressNode is in -webkit-user-select: all, but targetPosition is not, because Position::rootUserSelectAllForNode(target) != rootUserSelectAllForMousePressNode. It might be null, might be in some other user-select all.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.