[Webkit-unassigned] [Bug 91912] Adding "all" to -webkit-user-select

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91912





--- Comment #42 from Alice Cheng <alice_cheng at apple.com>  2012-08-17 14:44:33 PST ---
(From update of attachment 159176)
View in context: https://bugs.webkit.org/attachment.cgi?id=159176&action=review

Thanks Ryosuke for your review, will fix them. I have my questions below. Also, do you have any idea on the failure in cr-linux? I am quite confused with it.

>> Source/WebCore/page/EventHandler.cpp:834
>> +        newSelection.setExtent(targetPosition);
> 
> Don't we need to set this to the beginning of rootUserSelectAllForMousePressNode when the previous if condition is true?

Why? Do you mean setting the base or extent?

>> LayoutTests/editing/selection/user-select-all-selection.html:20
>> +                log("extending forward: selection should be the entire user-select-all area, which is (body, 1, body, 2).");
> 
> This is redundant since it just repeats the assert. We need to explain why it should be at (body, 1, body, 2).

Do you have any suggestion on explaining why it should be at (body, 1, body, 2)? Is it okay to just explain: "selection should be the entire user-select-all area"?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.