[Webkit-unassigned] [Bug 76009] Unlimited history items saved in WebProcessProxy

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=76009





--- Comment #5 from eglerik at gmail.com  2012-08-17 10:19:12 PST ---
(In reply to comment #4)

Currently, the only function that exposes m_backForwardListItemMap items outside of WebProcessProxy is WebProcessProxy::webBackForwardItem(uint64_t itemID). 

This is only interfaced with by the WebPageProxy class via the following 4 functions: 
  WebPageProxy::shouldGoToBackForwardListItem(uint64_t itemID, ...
  WebPageProxy::willGoToBackForwardListItem(uint64_t itemID, ...
  WebPageProxy::backForwardAddItem(uint64_t itemID)
  WebPageProxy::backForwardGoToItem(uint64_t itemID, ...

All the code paths I see for these functions get their itemID from WebBackForwardListProxy::historyItemToIDMap()

WebBackForwardListProxy::historyItemToIDMap() enforces the capacity of history items via WebPageProxy::backForwardRemovedItem(uint64_t itemID), which is where I'm suggesting WebProcessProxy::m_backForwardListItemMap should also maintain the history capacity by removing the same items.



call path for WebPageProxy::backForwardRemovedItem to WebBackForwardListProxy::removeItem:
--------------------------------------------------------------------------
WebPageProxy::backForwardRemovedItem(uint64_t itemID)
  calls: process()->send(Messages::WebPage::DidRemoveBackForwardItem(itemID), m_pageID);
  WebPage::didRemoveBackForwardItem(uint64_t itemID)
    calls: WebBackForwardListProxy::removeItem(itemID);
    WebBackForwardListProxy::removeItem(itemID) removes itemID from historyItemToIDMap()

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.