[Webkit-unassigned] [Bug 94329] [BlackBerry] Adapt to changes in the platform media player API
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Aug 17 09:41:01 PDT 2012
https://bugs.webkit.org/show_bug.cgi?id=94329
--- Comment #3 from Eric Carlson <eric.carlson at apple.com> 2012-08-17 09:41:34 PST ---
(From update of attachment 159094)
View in context: https://bugs.webkit.org/attachment.cgi?id=159094&action=review
This looks OK to me, but I know absolutely nothing about either the old or new platform player so I will let someone else give it a real review.
>> Source/WebCore/platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:175
>> + m_platformPlayer->cancelLoad();
>
> I think this and all the other null checks are changes in the behavior. Why is that needed now?
Because m_platformPlayer is allocated in load rather than in the constructor?
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list