[Webkit-unassigned] [Bug 93443] Web Inspector: Protocol Extension: Add "regionLayoutUpdate" event

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 17 05:09:34 PDT 2012


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
 Attachment #158311|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |

--- Comment #2 from Pavel Feldman <pfeldman at chromium.org>  2012-08-17 05:10:06 PST ---
(From update of attachment 158311)
View in context: https://bugs.webkit.org/attachment.cgi?id=158311&action=review

> Source/WebCore/inspector/InspectorCSSAgent.cpp:838
> +    if (!m_namedFlowCollectionsRequested.contains(documentNodeId)) {

I think m_namedFlowCollectionsRequested is superflous now that you have the more complete m_documentIdToNamedFlowSetMap.

> Source/WebCore/inspector/InspectorCSSAgent.cpp:868
> +            it = m_documentIdToNamedFlowSetMap.add(documentNodeId, NamedFlowSet()).iterator;

You should register this flow in the m_documentIdToNamedFlowSetMap from getNamedFlowCollection as well. I think it is better to do that in buildObjectForNamedFlow. You collection tracks elements that are sent to the front-end and the buildObjectForNamedFlow is a perfect place to do that.

> Source/WebCore/inspector/InspectorCSSAgent.cpp:1162
> +    int documentNodeId = m_domAgent->boundNodeId(document);

Looks like too much copypaste (add the "remove" parameter to the original method? reuse same implementation?)

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list