[Webkit-unassigned] [Bug 93971] [V8] Refactor away IsolatedWorld

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 17 02:58:44 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=93971





--- Comment #15 from Dan Carney <dcarney at google.com>  2012-08-17 02:59:15 PST ---
(In reply to comment #14)
> (From update of attachment 159059 [details])
> Looks OK.
> 
> By the way, do you have a plan to rename DOMWrapperWorld to IsolatedWorld? (You can do it in a follow-up patch.) A bunch of method names and variable names are using "isolatedWorld". In particular, some Chromium API names (e.g. evaluateInIsolatedWorld()) are using "IsolatedWorld", and it is difficult to rename Chromium APIs. So I think that it would be reasonable to rename DOMWrapperWorld to IsolatedWorld.

I have some follow up patches, but they just rename the constructors to createIsolatedWorld and createMainWorld.  I wasn't planning to rename back to IsolatedWorld as we are trying to match the JSC api a little more.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list