[Webkit-unassigned] [Bug 93597] Add DeviceController to support DOMWindow device events

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 17 02:37:10 PDT 2012


Gyuyoung Kim <gyuyoung.kim at samsung.com> changed:

           What    |Removed                     |Added
 Attachment #159052|0                           |1
           is patch|                            |

--- Comment #35 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-08-17 02:37:40 PST ---
(From update of attachment 159052)
View in context: https://bugs.webkit.org/attachment.cgi?id=159052&action=review

> Source/WebCore/ChangeLog:9
> +        and add proximity event to DeviceController for testing.

In my humble opinion, a patch for testing can be filed to new bug. But, if this patch is acceptable, I would like to recommend to add a newline for other description.

> Source/WebCore/dom/DeviceController.h:45
> +    DeviceController(Page*);

Missing explicit keyword.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list