[Webkit-unassigned] [Bug 93931] [EFL] Remove alloca usage.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93931





--- Comment #24 from Raphael Kubo da Costa (rakuco) <rakuco at webkit.org>  2012-08-17 00:25:44 PST ---
(From update of attachment 159017)
View in context: https://bugs.webkit.org/attachment.cgi?id=159017&action=review

> Source/WebCore/ChangeLog:3
> +        [EFL] Remove alloca usage and fix compile warning in WebCore

The original title about removing warnings from WebCore makes more sense here, as removing alloca is part of this process.

> Source/WebCore/ChangeLog:9
> +        To keep portable source code, alloca has been discouraged.
> +        Therefore, this patch removed alloca usage from EFL port.

I would mention here that we're unifying the approaches for the creation of Edje_Message_Float_Set messages, and getting rid of alloca is part of it, since it is not portable. It'd also be good to mention the compiler warnings you were getting.

> Source/WebCore/platform/efl/RenderThemeEfl.cpp:360
> +    edje_object_message_send(entry->o, EDJE_MESSAGE_FLOAT_SET, 0, msg);

See the comment in line 327; you do not need to send this message unconditionally.

> Source/WebCore/platform/efl/RenderThemeEfl.cpp:450
> +            EINA_LOG_ERR("Could not set file: %s", errmsg);

Not really related to this patch.

> Source/WebCore/platform/efl/ScrollbarEfl.cpp:175
> +    Edje_Message_Float_Set* msg = new(buffer.get()) Edje_Message_Float_Set;

The renaming of this variable makes the patch needlessly bigger.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.