[Webkit-unassigned] [Bug 94288] New: RenderBox::computeLogicalClientHeight is incorrectly named

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=94288

           Summary: RenderBox::computeLogicalClientHeight is incorrectly
                    named
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: ojan at chromium.org
                CC: eric at webkit.org, hyatt at apple.com,
                    esprehn at chromium.org, tony at chromium.org,
                    jchaffraix at webkit.org


clientHeight should include padding but exclude scrollbars (and RenderBox::clientHeight does!). RenderBox::computeLogicalClientHeight returns the box-sizing adjusted content height (excluding both padding and scrollbars). It's especially confusing because computeContentLogicalHeightUsing returns the content height not adjusted for box-sizing and including the scrollbar and computeLogicalHeightUsing returns the border-box size (including scrollbar obviously).

Can't think of a better name at the moment, but computeLogicalClientHeight is definitely wrong.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.