[Webkit-unassigned] [Bug 73819] [Gtk] Dojo toggle buttons should expose ROLE_TOGGLE_BUTTON not ROLE_PUSH_BUTTON

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73819





--- Comment #17 from chris fleizach <cfleizach at apple.com>  2012-08-16 09:17:25 PST ---
(From update of attachment 158769)
View in context: https://bugs.webkit.org/attachment.cgi?id=158769&action=review

after thinking about this patch more, I think we want to add a new WebCore accessibility role, and then just change the GTK mapping so the ToggleButtonRole (WebCore) maps to ATK_ROLE_TOGGLE_BUTTON
On the other platforms, it should still map to native button role. 

This will allow other platforms to identify toggle buttons in the same manner if they need to, without realizing they need to check if something is a toggleButton() after the fact

Similarly, I feel like these likes that I see in the AXWrapperAtk.cpp class can be removed and you can rely on atkRole to return the right thing, because PasswordField should be a WebCore role

if (coreObject->isPasswordField())
539539        return ATK_ROLE_PASSWORD_TEXT;

> LayoutTests/ChangeLog:8
> +        Added a extra rule on the mapping of WebCore accessibility roles

Comment should say

"Added a test to verify that when aria-pressed is present, buttons will have the appropriate role"

> LayoutTests/platform/gtk/accessibility/aria-toggle-button-role.html:17
> +    obj2 = accessibilityController.focusedElement;

You should also test the case when aria-pressed is empty here.

and you should test the case when aria-pressed is on an non-button role

> Source/WebCore/ChangeLog:10
> +        ATK_ROLE_TOGGLE_BUTTON when required.

Comment should say:
"Added an extra rule to the ATK accessibility role mappings based on whether aria-pressed is present.
http://www.w3.org/TR/wai-aria/states_and_properties#aria-pressed"

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:493
> +    // From http://www.w3.org/TR/wai-aria/states_and_properties#aria-pressed

Comment should say

"If aria-pressed is present, then it should be exposed as a toggle button.
http://www.w3.org/TR/wai-aria/states_and_properties#aria-pressed"

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.