[Webkit-unassigned] [Bug 89197] [Chromium] Implements DeviceMotion

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=89197





--- Comment #41 from Hans Wennborg <hans at chromium.org>  2012-08-16 05:44:27 PST ---
(From update of attachment 158780)
Thanks Amy, this looks great.

I have two tiny nits, and I suppose the Mac build files need an update, but I'm mostly interested to hear if Darin is happy with the overall design now.

View in context: https://bugs.webkit.org/attachment.cgi?id=158780&action=review

> Source/Platform/chromium/public/WebDeviceMotionDetector.h:41
> +    virtual void stopUpdating() = 0;

i think these two should also use WEBKIT_ASSERT_NOT_REACHED(); instead of "= 0".

> Source/WebCore/platform/chromium/DeviceMotionDetectorInternal.cpp:51
> +    // TODO(aousterh): allow for multiple DeviceMotionControllers or make

nit: in webkit, i think "// FIXME: Foo bar." is the commonly used syntax.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.