[Webkit-unassigned] [Bug 93090] Web Inspector: requests filtering in network tab

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93090


Vsevolod Vlasov <vsevik at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #158779|review?                     |review-
               Flag|                            |




--- Comment #27 from Vsevolod Vlasov <vsevik at chromium.org>  2012-08-16 05:13:21 PST ---
(From update of attachment 158779)
View in context: https://bugs.webkit.org/attachment.cgi?id=158779&action=review

> Source/WebCore/inspector/front-end/NetworkPanel.js:1072
> +        this._highlightMatchedRequests([], false, "");

"" doesn't look like a regexp to me. Please annotate new methods to make sure we catch such errors.

> Source/WebCore/inspector/front-end/NetworkPanel.js:1106
> +        if (regExp.test(""))

I don't think this is needed.

> Source/WebCore/inspector/front-end/NetworkPanel.js:1155
> +                this._toggleLargerRequests();

This should be in highlight... method because it's needed both for search and filtering.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.