[Webkit-unassigned] [Bug 93931] [EFL] Remove alloca usage.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 15 23:52:25 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=93931





--- Comment #15 from Kangil Han <kangil.han at samsung.com>  2012-08-15 23:52:57 PST ---
(In reply to comment #14)
> OK, I've managed to reproduce that warning with my code snippet by calling edje_object_message_send() in it (clang still doesn't produce any warning).
> 
> There are two possible solutions here:
> 
> 1) Use plain old malloc() here specifying the amount of bytes we want to allocate and avoiding all those casts.
> 
> 2) Refining Kangil's proposed patch.
> 
> Solution 2) is interesting because the static_cast<void*>() is not necessary, so we can remove some bloat. We could also pass the allocated memory to an OwnPtr, thus avoiding the need to free the memory manually.
> 
> Kangil, can you produce a new patch following those suggestions (please also refrain from changing variable names to keep it as short as possible)?

Sure, I will get back with an updated one. ;-)
Thanks!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list