[Webkit-unassigned] [Bug 94122] win64 compile error fix for BinaryPropertyList.cpp

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=94122


Brent Fulgham <bfulgham at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #158589|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #2 from Brent Fulgham <bfulgham at webkit.org>  2012-08-15 20:47:05 PST ---
(From update of attachment 158589)
View in context: https://bugs.webkit.org/attachment.cgi?id=158589&action=review

I think the intent of this change is good, but please switch to the more explicit C++-style cast; I think this is just a static_cast<>.

> Source/WebCore/platform/cf/BinaryPropertyList.cpp:700
> +            appendByte((unsigned char)(asciiStringMarkerByte | length));

We use C++-style casts in the Coding Guideline:

static_cast<unsigned char>(asciiStringMarkerByte | length)

> Source/WebCore/platform/cf/BinaryPropertyList.cpp:709
> +            appendByte((unsigned char)(unicodeStringMarkerByte | length));

Ditto.

> Source/WebCore/platform/cf/BinaryPropertyList.cpp:726
> +        appendByte((unsigned char)(asciiStringMarkerByte | length));

Ditto

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.