[Webkit-unassigned] [Bug 94124] clipboardwin compile error for win64

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 15 20:43:47 PDT 2012


Brent Fulgham <bfulgham at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #158592|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |

--- Comment #2 from Brent Fulgham <bfulgham at webkit.org>  2012-08-15 20:44:20 PST ---
(From update of attachment 158592)
View in context: https://bugs.webkit.org/attachment.cgi?id=158592&action=review

Looks fine to me (and the EWS).  Please revise the ChangeLog notes and I think we are ready to land/

> Source/WebCore/ChangeLog:5
> +

I think you should include your helpful explanation here:

"The clipboard utilities code uses std::min with one unsigned int parameter and one size_t parameter. This causes a problem when compiling for 64-bit windows because the two types are not the same size.  To resolve this issue, we specify the template type as the type the return value is being cast into."

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list