[Webkit-unassigned] [Bug 93912] Implement UndoManager's V8 bindings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93912





--- Comment #14 from Kentaro Hara <haraken at chromium.org>  2012-08-15 16:42:44 PST ---
(In reply to comment #13)
> > > Source/WebCore/bindings/v8/DOMTransaction.cpp:87
> > > +    return !function.IsEmpty() && function->IsFunction();
> > 
> > Nit: I would prefer !(function.IsEmpty() || !function->IsFunction()) for consistency.
> 
> Consistency with what?  (I don't mind either way---I'm just curious.)

'value.IsEmpty() || !value.IsXXX()' is a typical pattern for the type check (also used in this patch). I don't mind either way. Fewer negatives might be better.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.