[Webkit-unassigned] [Bug 93912] Implement UndoManager's V8 bindings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93912





--- Comment #10 from Adam Barth <abarth at webkit.org>  2012-08-15 13:32:15 PST ---
(From update of attachment 158308)
View in context: https://bugs.webkit.org/attachment.cgi?id=158308&action=review

> LayoutTests/editing/undomanager/domtransaction-survives-gc.html:17
> +var u = document.undoManager;

u -> please don't use single letter variable names.

> LayoutTests/editing/undomanager/domtransaction-survives-gc.html:32
> +	if (window.GCController)
> +		GCController.collect();

If you include ../../resources/gc.js you can call gc() in the global scope, which will work both in DumpRenderTree and in browsers.

> LayoutTests/editing/undomanager/undomanager-transact.html:36
> +        "execute": function() {
> +            edit.innerHTML += "1e ";
> +        },
> +        "undo": function() {
> +            edit.innerHTML += "1u ";
> +        },
> +        "redo": function() {
> +            edit.innerHTML += "1r ";
> +        }

Can you test what the |this| value is during these callbacks?

Also, please add tests for the use-after-free issues and please also test what happens when we re-enter UndoManager by calling undoManager functions during callbacks.

It would also be good to test the isolated world interactions via testRunner.executeScriptInIsolatedWorld (I'm not sure if that name is 100% accurate).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.