[Webkit-unassigned] [Bug 93971] [V8] Refactor away IsolatedWorld

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93971





--- Comment #6 from Dan Carney <dcarney at google.com>  2012-08-15 03:13:15 PST ---
(From update of attachment 158389)
View in context: https://bugs.webkit.org/attachment.cgi?id=158389&action=review

>>> Source/WebCore/bindings/v8/DOMWrapperWorld.h:45
>>> +    static PassRefPtr<DOMWrapperWorld> create(int worldId = mainWorldId) { return adoptRef(new DOMWrapperWorld(worldId)); }
>> 
>> Can you make createMainWorld be a separate function?  It's a bit too tempting to call create() and duplicate the main world.
> 
> This is transitional.  There are 2 places in the code where DOMWrapperWorld() was being called, as opposed to IsolatedWorld().  This logic replicates that.  I think those are only called in tests, but I'm not certain.

The problematic calls are in WebViewImpl  http://code.google.com/p/chromium/source/search?q=DOMWrapperWorld%3A%3Acreate&origq=DOMWrapperWorld%3A%3Acreate&btnG=Search+Trunk
Do you happen to know if I can replace them with a call to mainThreadNormalWorld()?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.