[Webkit-unassigned] [Bug 93090] Web Inspector: requests filtering in network tab
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Aug 14 23:50:56 PDT 2012
https://bugs.webkit.org/show_bug.cgi?id=93090
Vsevolod Vlasov <vsevik at chromium.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #158360|review? |review-
Flag| |
--- Comment #23 from Vsevolod Vlasov <vsevik at chromium.org> 2012-08-14 23:51:25 PST ---
(From update of attachment 158360)
View in context: https://bugs.webkit.org/attachment.cgi?id=158360&action=review
> Source/WebCore/ChangeLog:8
> + New feature: there are both search bar and filter bar in network tabw. One can swich them using checkbox "filtering".
Please fix typos.
> Source/WebCore/inspector/front-end/SearchController.js:46
> + this._firstRowElement.createChild("td");
Why is this needed?
> Source/WebCore/inspector/front-end/SearchController.js:57
> +
Extra blank line.
> Source/WebCore/inspector/front-end/SearchController.js:74
> + this._filterInputElement.addEventListener("keydown", this._onKeyDown.bind(this), true);
keydown handler has some search specific logic that should be treated carefully.
> Source/WebCore/inspector/front-end/SearchController.js:79
> + this._secondRowElement.createChild("td");
Why is this needed?
> Source/WebCore/inspector/front-end/SearchController.js:125
> +
Extra blank line.
> Source/WebCore/inspector/front-end/SearchController.js:136
> + this._searchOrFilterQuery = "";
unused
> Source/WebCore/inspector/front-end/SearchController.js:255
> + this._performSearch(this._searchInputElement.value);
Please remove this line, we don't want to change search behavior.
> Source/WebCore/inspector/front-end/SearchController.js:432
> + this._performSearch(this._filterInputElement.value, false, false);
Please use this._searchInputElement for consistency.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list