[Webkit-unassigned] [Bug 93832] text-combine falls back to none rather than scale when wider than 1.1em

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93832





--- Comment #6 from Koji Ishii <kojiishi at gmail.com>  2012-08-14 22:49:37 PST ---
* ChangeLog: I think you should mention it's not conformant with the current WD, along with the spec URL, rather than just saying "annoying for many Japanese users".
* *-expected.png: Are they correct? I guess expectations are to text-combine with scale, no?
* You're restoring CTM by multiplying (1 / combinedComplessScale), but I don't think it's reliable nor fast. I think it's better to save/restore.
* Is "m_emWidth = description.computedSize() * textCombineMargin" correct? We should scale to 1em, not to 1.1em, correct?
* I think you should leave a comment in source file too why you always set m_isCombined to true, and fallback code should be removed. I actually think it might be better to remove them, because it reduces footprint, but I can't be sure how reviewers would say, so you may wait for the real reviewer, up to you.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.