[Webkit-unassigned] [Bug 85856] [Chromium] Cannot show the left side of an RTL element with a vertical scrollbar

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 14 20:41:07 PDT 2012


--- Comment #38 from Tony Chang <tony at chromium.org>  2012-08-14 20:41:37 PST ---
(From update of attachment 158240)
View in context: https://bugs.webkit.org/attachment.cgi?id=158240&action=review

> Source/WebCore/ChangeLog:27
> +        (WebCore::RenderBlock::paintChildren): Move the paint rectangles of RTL children right.

It feels wrong that we're moving the paint rectangles.  Why is it better to move the paint offset rather than changing the RenderObject's offset?

> Source/WebCore/dom/Element.cpp:420
> +    if (RenderBox* renderer = renderBox()) {
> +        LayoutUnit clientLeft = renderer->clientLeft();

Nit: I would change this to early return if renderer is 0.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list