[Webkit-unassigned] [Bug 74346] Text selection in text area in auto scroll mode goes wrong.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=74346


Ojan Vafai <ojan at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #157713|review?                     |review-
               Flag|                            |




--- Comment #2 from Ojan Vafai <ojan at chromium.org>  2012-08-14 19:01:39 PST ---
(From update of attachment 157713)
View in context: https://bugs.webkit.org/attachment.cgi?id=157713&action=review

R- for the 100ms timeout. The C++ side looks good to me.

> LayoutTests/fast/events/autoscroll-in-textarea.html:57
> +        var x = textarea.offsetLeft + 20;
> +        var y = textarea.offsetTop + 8;

Can you make these less magic? For x, you can do textarea.offsetLeft + textarea.offsetWidth / 2.

For y, would adding 1 be enough?

> LayoutTests/fast/events/autoscroll-in-textarea.html:63
> +    setTimeout(autoscrollTestPart2, 100);

Do you need this 100ms? 0 should be sufficient I would think. No need to make the test take ~100ms longer.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.