[Webkit-unassigned] [Bug 93643] Preserve styling elements in DeleteSelectionCommand

Tue Aug 14 15:25:17 PDT 2012

https://bugs.webkit.org/show_bug.cgi?id=93643

Alice Cheng <alice_cheng at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #158111|0                           |1
        is obsolete|                            |
 Attachment #158111|commit-queue?               |
               Flag|                            |
 Attachment #158424|                            |review?, commit-queue?
               Flag|                            |

--- Comment #40 from Alice Cheng <alice_cheng at apple.com>  2012-08-14 15:25:45 PST ---
Created an attachment (id=158424)
 --> (https://bugs.webkit.org/attachment.cgi?id=158424&action=review)
Proposed Patch

Modified command to preserve "undoness" of DeleteSelectionCommand
Modified the moving, so that it only moves when <head> is content editable

Also Thank Ryosuke and Darin for the review and comments!! I do have a question on Ryosuke's comment: if we do not remove these elements in certain places, then where shall we keep them, if their parents are to be removed as well (for example their parents are in a DeleteSelectionComand's selection)? <head> was a choice, since according to W3C, it is a safer place for these elements. Maybe you have better understanding on the removing procedure than i do. Let me know =)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.